Lars Volker has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/2431

Change subject: IMPALA-2918: Unit test framework for simple scheduler
......................................................................

IMPALA-2918: Unit test framework for simple scheduler

The SimpleScheduler class is currently hard to change because of the lack of 
comprehensive
tests. This change adds support classes to make writing tests easier.

The overall testing approach looks like this: Each test builds a list of hosts 
and a plan,
both to which elements can be added using various helper methods. Then 
scheduling can be
tested by instantiating SchedulerWrapper and calling Compute(...). The result 
can be
verified using a set of helper methods. There are also helper methods to modify 
the
internal state of the scheduler between subsequent calls to 
SchedulerWrapper::Compute().

The model currently comes with some known limitations:

- Files map 1:1 to blocks and to scan ranges.
- All files have the same size (i.e., 1). Tables that differ in size can be 
expressed as
  having a different number of files.
- We don't support multiple backends on a single host.
- Ports are assigned to hosts automatically and are not configurable by the 
test.

Change-Id: Ia7aee9b16067e8728a8e96d4def3e568ad21f4bf
---
M be/src/scheduling/scheduler.h
M be/src/scheduling/simple-scheduler-test.cc
M be/src/scheduling/simple-scheduler.cc
M be/src/scheduling/simple-scheduler.h
4 files changed, 1,141 insertions(+), 192 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala refs/changes/31/2431/14
-- 
To view, visit http://gerrit.cloudera.org:8080/2431
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia7aee9b16067e8728a8e96d4def3e568ad21f4bf
Gerrit-PatchSet: 14
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Lars Volker <[email protected]>
Gerrit-Reviewer: Lars Volker <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Silvius Rus <[email protected]>

Reply via email to