Jim Apple has posted comments on this change.

Change subject: IMPALA-3375: Improve TopN performance with a trivial Compare 
object.
......................................................................


Patch Set 2:

(7 comments)

http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/exec/topn-node.cc
File be/src/exec/topn-node.cc:

Line 77:       new priority_queue<Tuple*, vector<Tuple*>, 
ComparatorWrapper<TupleRowComparator> >(
> move that c'tor call to a separate line so you don't have to break it up
Done


http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/service/impala-server-callbacks.cc
File be/src/service/impala-server-callbacks.cc:

Line 282
> yeah, that's a weird one
:-)


http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/service/impala-server.h
File be/src/service/impala-server.h:

Line 621:   struct QueryStateRecordComparator {
> is this <=? in that case, better to call it QueryStateLessThan
Done


http://gerrit.cloudera.org:8080/#/c/2936/2/be/src/util/tuple-row-compare.h
File be/src/util/tuple-row-compare.h:

Line 40: template <typename T>
> maybe call this one Comparator as opposed to just T, to make it clear that 
Done


Line 48: rhs
> space before.
Done


Line 115:   bool Less(TupleRow* lhs, TupleRow* rhs) const {
> is 'Less' an stl standard? otherwise LessThan seems more typical (as in DCH
Kindof. std::less is a thing, rather than std::less_than.


Line 157:   bool Equal(Tuple* x, Tuple* y) {
> is anyone wrapping this
Nope. Why do you ask?


-- 
To view, visit http://gerrit.cloudera.org:8080/2936
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I24755227b5bbbca6ad7c7d31d9bb8e132ca89e11
Gerrit-PatchSet: 2
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Jim Apple <[email protected]>
Gerrit-Reviewer: Dan Hecht <[email protected]>
Gerrit-Reviewer: Jim Apple <[email protected]>
Gerrit-Reviewer: Marcel Kornacker <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to