Mostafa Mokhtar has posted comments on this change. Change subject: IMPALA-1928 : Impala ODBC bad performance with Kerberos mechanism ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/2769/2/be/src/rpc/thrift-client.h File be/src/rpc/thrift-client.h: Line 144: transport_ = socket_; > I think we shouldn't call WrapClientTransport if socket_ is null. Can you j What is the expected behavior if socket_ is NULL? -- To view, visit http://gerrit.cloudera.org:8080/2769 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iebcf6457091aef1fc0e5bd1549b3fcbafc5560d9 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
