Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1633: Impala server GetOperationStatus() should return detail sql error code and message when query fails ......................................................................
Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/3094/2//COMMIT_MSG Commit Message: Line 7: IMPALA-1633: Impala server GetOperationStatus() should return detail sql error code and message when query fails subject line should be ~50-60 characters max http://gerrit.cloudera.org:8080/#/c/3094/2/be/src/service/impala-hs2-server.cc File be/src/service/impala-hs2-server.cc: Line 942: if (!entry->second->query_status().ok()) { (Related to what Dan mentioned) As we chatted about in person, it'd be nice to have some DCHECKs here. http://gerrit.cloudera.org:8080/#/c/3094/2/tests/hs2/hs2_test_suite.py File tests/hs2/hs2_test_suite.py: Line 215: status state, right? you're checking against operationState Line 215: status state Line 216: extra spaces? Line 217: operstion typo Line 217: tatus state Line 218: GetOperationStatus every interval seconds, returning the TGetOperationStatusResp""" , or raises an assertion if it times out. Line 226: 'Did not reach expected operation status in time can you include what it is and what it was expected to be? -- To view, visit http://gerrit.cloudera.org:8080/3094 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Icb792f88286779fcf2ce409828de818bc4e80bed Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
