Henry Robinson has posted comments on this change. Change subject: IMPALA-3282: TBinaryProtocol buffers consume unbounded memory ......................................................................
Patch Set 3: Did you look into whether it's possible to do the same thing by subclassing TBinaryProtocolT with a new implementation of readStringBody() (i.e. putting the diff into Impala?). The more patches we accrue, the harder an upgrade of Thrift becomes. -- To view, visit http://gerrit.cloudera.org:8080/3201 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I58bdc899e604bde2f5b2d5360f79537ce25715ee Gerrit-PatchSet: 3 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: No
