Alex Behm has posted comments on this change.

Change subject: IMPALA-3369: Add ALTER TABLE SET COLUMN STATS statement.
......................................................................


Patch Set 6:

(3 comments)

http://gerrit.cloudera.org:8080/#/c/3189/6/fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetColumnStats.java
File 
fe/src/main/java/com/cloudera/impala/analysis/AlterTableSetColumnStats.java:

Line 20: import org.kududb.client.shaded.com.google.common.base.Preconditions;
> ??
Ugh not again. Sorry. Eclipse. Kudu seems to be doing something weird though.


http://gerrit.cloudera.org:8080/#/c/3189/6/fe/src/main/java/com/cloudera/impala/catalog/ColumnStats.java
File fe/src/main/java/com/cloudera/impala/catalog/ColumnStats.java:

Line 60:     }
> single line
Done


Line 262:   public void update(StatsKey key, Object value) {
> Float and Long are both subclasses of Number. Maybe use that instead?
Ahh nice. Done.


-- 
To view, visit http://gerrit.cloudera.org:8080/3189
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I45cd8aa7241ea962788ba9ca7d0bbfd864c4304f
Gerrit-PatchSet: 6
Gerrit-Project: Impala
Gerrit-Branch: cdh5-2.6.0_5.8.0
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Bharath Vissapragada <[email protected]>
Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]>
Gerrit-HasComments: Yes

Reply via email to