Matthew Jacobs has posted comments on this change. Change subject: IMPALA-1440: test for insert mem limit ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3245/1/testdata/workloads/functional-query/queries/QueryTest/insert.test File testdata/workloads/functional-query/queries/QueryTest/insert.test: Line 850: functional_parquet right now this still runs for all table types right? should we restrict this to only run when the table type is parquet? otherwise this gets run much more frequently than it needs to be. I'm not sure if we have something like insert_parquet.test for parquet specific test cases, but it wouldn't be too much of a pain to add if not. -- To view, visit http://gerrit.cloudera.org:8080/3245 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I8583c60d648af9eedc956315df5ac3c3d6608704 Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
