Tim Armstrong has posted comments on this change.

Change subject: IMPALA-3632: Add script for runnig cppclean over the BE code.
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3237/1/CMakeLists.txt
File CMakeLists.txt:

Line 361: if (DUMP_INCLUDE_PATHS)
> I originally tried that but couldn't make it work because the commands I wa
Ah ok,  I didn't realise it was that restrictive about what you could include 
in a target. This seems fine then.


-- 
To view, visit http://gerrit.cloudera.org:8080/3237
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I5cd064344bdf47d77058fb570f034bb324308103
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Alex Behm <[email protected]>
Gerrit-Reviewer: Alex Behm <[email protected]>
Gerrit-Reviewer: Michael Ho <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: Yes

Reply via email to