Tim Armstrong has posted comments on this change. Change subject: IMPALA-3223: Supports download of CDH components from S3. ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3333/2/bin/bootstrap_toolchain.py File bin/bootstrap_toolchain.py: Line 288: def download_cdh_components(toolchain_root, cdh_components): > I share your concern and I also tried to come up with a way to not download I have SKIP_TOOLCHAIN_BOOTSTRAP set to true in my environment, so I guess it wouldn't necessarily affect me. I think I prefer the first option too. It may also be worth thinking about what we should do if the md5sum is unavailable (e.g. infra outage). It seems like it's not necessarily worth aborting the build if there's already some package present. -- To view, visit http://gerrit.cloudera.org:8080/3333 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I16fa79db0005554cc0a116e74775647ba99f8dda Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
