Tim Armstrong has posted comments on this change.

Change subject: IMPALA-1240: add back spilling sort now that sorter is not flaky
......................................................................


Patch Set 1:

For context, this was originally removed in this commit:

commit 4e843487b27b07dd144be689aad3a1bfeb5ad499
Author: Dan Hecht <[email protected]>
Date:   Tue Sep 16 16:23:44 2014 -0700

    IMPALA-1240: TestCancellationFullSort hits mem limit of 300MB with 
tpch_parquet
    
    The test sets a mem_limit of 300MB and does:
    
       delay(t)
       assert(query_state != EXCEPTION)
       cancel()
    
    If the mem_limit is hit before the delay completes, the assert will fail.  
So,
    the test is racy.  It appears we are right on the 300 MB memory limit (on my
    machine, the query completes with peak mem usage in the high 200 MB).
    
    I'm not sure why the mem_limit dimension was added, but given that it makes
    the test racy and doesn't seem to add value, let's remove it and re-enable 
the
    test.
    
    Change-Id: I63767161bec6d7d6cd3de2e4563425297ffccb0d
    Reviewed-on: http://gerrit.sjc.cloudera.com:8080/4366
    Reviewed-by: Alex Behm <[email protected]>
    Tested-by: jenkins
    (cherry picked from commit e876c9e3f6ae4a6914c0d0976eb89dc45b8802b2)
    Reviewed-on: http://gerrit.sjc.cloudera.com:8080/4375
    Reviewed-by: Daniel Hecht <[email protected]>

-- 
To view, visit http://gerrit.cloudera.org:8080/3356
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I88056db2eac3fa91bef85284a516be303f25333d
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Tim Armstrong <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-Reviewer: Tim Armstrong <[email protected]>
Gerrit-HasComments: No

Reply via email to