David Knupp has posted comments on this change. Change subject: xfail s3a_keys_do_not_work custom cluster test ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3379/2/tests/custom_cluster/test_s3a_access.py File tests/custom_cluster/test_s3a_access.py: Line 68: pytest.xfail("IMPALA-3664: Feature unsupported in this branch") So, putting this here has the equivalent effect of putting a return statement as the first line of the function -- no lines beyond this point get executed. But it seems to me like this method actually contains two distinct test cases: - Confirm that the SELECT ... statement *fails* with bad S3 credentials - Confirm that the CREATE ... statement *succeeds* with bad S3 credentials because it's going through the Hive metastore Do you really want to forgo both of these test cases? Or only the test for the SELECT statement? -- To view, visit http://gerrit.cloudera.org:8080/3379 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I4f9948fafd2f5d2363e88a60e67cf751f2fa5f93 Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-2.6.0_5.8.0 Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: David Knupp <[email protected]> Gerrit-HasComments: Yes
