Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-3753: Disable create table test for old aggs and joins
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/3430/1/tests/metadata/test_ddl.py
File tests/metadata/test_ddl.py:

PS1, Line 198:   # TODO: There is a query in QueryTest/create-table that 
references nested types, which
             :   # forces us to skip the entire test case if old aggs and joins 
are enabled. This needs
             :   # to be fixed.
Can you pull out the affected tests into a separate file, e.g. 
nested-types-create-table.test and run that separately, and just put the @Skip 
on that test?

That's what we do for a number of other similar cases. See other nested-types 
specific test files:

testdata/workloads/functional-query/queries/QueryTest/nested-types-*


-- 
To view, visit http://gerrit.cloudera.org:8080/3430
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Ib9615bbb8214a231527cc4cd07521a5d21082a5c
Gerrit-PatchSet: 1
Gerrit-Project: Impala
Gerrit-Branch: cdh5-trunk
Gerrit-Owner: Taras Bobrovytsky <[email protected]>
Gerrit-Reviewer: Matthew Jacobs <[email protected]>
Gerrit-HasComments: Yes

Reply via email to