Bharath Vissapragada has posted comments on this change. Change subject: IMPALA-3680: Cleanup the scan range state after failed hdfs cache reads ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3313/6//COMMIT_MSG Commit Message: PS6, Line 13: endup > Typo: "endup" Done http://gerrit.cloudera.org:8080/#/c/3313/6/testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl File testdata/cluster/node_templates/common/etc/hadoop/conf/hdfs-site.xml.tmpl: PS6, Line 88: <value>1073741824</value> > Is this a reasonable default value for our minicluster, or is this needed o Currently only test_hdfs_caching_fallback_path caches a larger table (~120MB). (This is to test a specific code path that was untested before), So ideally I can reduce it to say 200MB and still get the work done. As such I don't see any risks of changing this as it is quite common in any deployment that intends to use hdfs caching. http://gerrit.cloudera.org:8080/#/c/3313/6/tests/query_test/test_hdfs_caching.py File tests/query_test/test_hdfs_caching.py: PS6, Line 105: get_random_id(5)) > Instead of this, you could use the "testid_checksum" fixture, along with a Done PS6, Line 114: execute_query > execute_query_expect_success() here and in other places? Done -- To view, visit http://gerrit.cloudera.org:8080/3313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I0a9ea19dd8571b01d2cd5b87da1c259219f6297a Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Bharath Vissapragada <bhara...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
