Tim Armstrong has posted comments on this change. Change subject: IMPALA-3674: Lazy materialization of LLVM module bitcode. ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3220/4/be/src/codegen/llvm-codegen.cc File be/src/codegen/llvm-codegen.cc: Line 249: bool error = Linker::linkModules(*module_, std::move(new_module)); > Would you mind sharing with me offline the problem you ran into ?We may nee That sounds good to me. I think it would be good if possible to add a IR UDF test coverage where we have: a) a query using multiple IR udfs (if we don't have this) to make sure they get linked correctly b) an IR UDF that references a non-inlined function in the same module, to make sure it's linked across directly. c) an IR UDF that references a cross-compiled IR function from the impala IR module, e.g. a decimal operator (if this is even reasonably possible) -- To view, visit http://gerrit.cloudera.org:8080/3220 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6ed7862fc5e86005ecea83fa2ceb489e737d66b2 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Mostafa Mokhtar <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
