Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3711: Remove unnecessary privilege checks in getDbsMetadata() ......................................................................
Patch Set 13: (1 comment) http://gerrit.cloudera.org:8080/#/c/3371/13/fe/src/main/java/com/cloudera/impala/catalog/Catalog.java File fe/src/main/java/com/cloudera/impala/catalog/Catalog.java: PS13, Line 175: if (matcher == null) return Collections.emptyList(); > Setting the pattern of the matcher to null is the problem we are trying to I believe Henry's comment has broader implications than simply pushing the check to a different function. Even with all the changes that we went through in the last patches, the behavior is still a bit confusing, the reason being that in several cases we call some functions with a null PatternMatcher and we have extra logic to handle this case. What Henry suggests is essentially eliminating that case altogether. I.e. we never pass a null PatternMatcher. Instead, we encode that behavior (that corresponds to the null matcher) into the PatternMatcher's implementation. Henry plz correct me if I misunderstood your comment. Even though we may have to revert many of the changes you made in the last patches I believe it's a great idea. -- To view, visit http://gerrit.cloudera.org:8080/3371 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I17d8c5b9fb12483e4b01b819fba48b6849311a14 Gerrit-PatchSet: 13 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Huaisi Xu <[email protected]> Gerrit-Reviewer: Dimitris Tsirogiannis <[email protected]> Gerrit-Reviewer: Henry Robinson <[email protected]> Gerrit-Reviewer: Huaisi Xu <[email protected]> Gerrit-HasComments: Yes
