Michael Ho has posted comments on this change. Change subject: IMPALA-1731,IMPALA-3868: Float values are not parsed correctly ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/3622/2/be/src/util/string-parser.h File be/src/util/string-parser.h: PS2, Line 377: We'll be a little loose : // here and interpret any column with "inf" as a prefix as infinity rather than : // checking every remaining byte. > Yeah. If we think people may depend on this functionality then we should ma IMHO, putting the new fix in strict mode seems to complicate the code further than necessary as we have to maintain both the buggy old behavior and the new one. We should try to make a call whether to fix the problem now or we should just defer the entire change to C6. -- To view, visit http://gerrit.cloudera.org:8080/3622 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9e17d0f051b300a22a520ce34e276c2d4460d35e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Attila Jeges <[email protected]> Gerrit-Reviewer: Attila Jeges <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-HasComments: Yes
