Dan Hecht has posted comments on this change. Change subject: IMPALA-3854: Fix use-after-free in HdfsTextScanner::Close() ......................................................................
Patch Set 4: Code-Review+2 (2 comments) http://gerrit.cloudera.org:8080/#/c/3630/4//COMMIT_MSG Commit Message: PS4, Line 23: ClearlStreams typo http://gerrit.cloudera.org:8080/#/c/3630/4/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: PS4, Line 194: decompression_type_ it looks like this is only set in ProcessSplit() if we found a tuple starting in the range. in the case we don't, will this still work okay? (I think it's okay, but just want to double check) -- To view, visit http://gerrit.cloudera.org:8080/3630 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ia88f6285563ff669ae215af22ed2d45e5398adae Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-HasComments: Yes
