Michael Brown has posted comments on this change. Change subject: Enable TPC-H workload for Kudu tables ......................................................................
Patch Set 6: (2 comments) Cool, always good to see more pytest-isms. http://gerrit.cloudera.org:8080/#/c/3633/6/tests/query_test/test_tpch_queries.py File tests/query_test/test_tpch_queries.py: PS6, Line 32: return "TPC-H: Q{}".format(val) Unfortunately '{}'.format('str') isn't Python 2.6 compatible, which is what most of our Jenkins jobs use. You'll need to use something like '...Q{0}'.format(val) PS6, Line 35: [1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20, 21, 22], xrange(1,23) ? Or do you want them listed out so they can be skipped if needed? -- To view, visit http://gerrit.cloudera.org:8080/3633 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3a5de71fefa92a78970226d8f49ef445d28f9289 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
