Tim Armstrong has posted comments on this change. Change subject: IMPALA-2033: Netezza compatibility functions quote_ident ......................................................................
Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/3263/4/be/src/exprs/expr-test.cc File be/src/exprs/expr-test.cc: PS4, Line 2011: ABC100 I didn't mean for you to change this: this is wrong in a different way. The point of quote_ident is to preserve the identifier exactly, including the case of the characters. Transforming lower to upper case doesn't do this. It would be ok if the input was ABC100, since unquoted identifiers are automatically converted to upper case, but this is wrong for abc100: you need the result to be "abc100" so that lower-case is preserved. -- To view, visit http://gerrit.cloudera.org:8080/3263 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Idbac4cd10fe08a6bd4871a03ba3b5f2c20fa8ee1 Gerrit-PatchSet: 4 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Shirish Gajera <[email protected]> Gerrit-Reviewer: Shirish Gajera <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
