Feng Guangyuan has posted comments on this change. Change subject: IMPALA-3622: Unacceptable '\0' used as fields terminator when creating tables ......................................................................
Patch Set 2: (3 comments) Yes Jim, I will end it. Thanks for your patient, first. Indeed, I need your help. I don't know whether my previous comments have described the bug appearance or not, and where to add tests. Hope you give me some suggestions, thank you very much.:) http://gerrit.cloudera.org:8080/#/c/3266/1//COMMIT_MSG Commit Message: Line 11: is not allowed to be a delimiter in Hive or Impala, actually. Impala > This doesn't really explain - can you summarize the bug that occurs, please According to the official documentation, in IMPALA 1.3.1 and higher, the delimiter character ‘\0’ is legal to use the ASCII 0 (null) character for text tables, and a SQL sample is provided. But it fails in practice, running with impala-shell.Also I tried ‘\u0000’.After investigated, I found it was translated as empty string literal through getUnescapedValueorNull(), due to delimiter '\0', i.e. "" as the delimiter to be handled in the subsequent internal process. More details see: [https://issues.cloudera.org/browse/IMPALA-3622] Line 14: > until when? I mean I am not sure this patch has supplied the best approach to solve this issue,but it's confirmed after you approve it. http://gerrit.cloudera.org:8080/#/c/3266/1/fe/src/main/java/com/cloudera/impala/catalog/RowFormat.java File fe/src/main/java/com/cloudera/impala/catalog/RowFormat.java: Line 60: if (fieldDelimiter_ != null && fieldDelimiter_.equals("\0")) return new String("0"); > What happens if fieldDelimiter is '\0' and lineDelimiter is '\0'? ImpalaRuntimeException: Error making 'createTable' RPC to Hive Metastore. More details, please see issue: https://issues.cloudera.org/browse/IMPALA-3622 -- To view, visit http://gerrit.cloudera.org:8080/3266 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id67634282ecf0161a3aa7a3d7f8711b49828668e Gerrit-PatchSet: 2 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Feng Guangyuan <[email protected]> Gerrit-Reviewer: Feng Guangyuan <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-HasComments: Yes
