Dan Hecht has posted comments on this change. Change subject: IMPALA-3843: Update warning for non-SSSE3 CPUs ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3837/1/be/src/util/cpu-info.cc File be/src/util/cpu-info.cc: PS1, Line 137: WARNING I think we should leave this ERROR. We run this code before initializing google logging, so IIRC, ERROR will send it to stderr so that it's visible. The written text looks good. -- To view, visit http://gerrit.cloudera.org:8080/3837 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id242b310715c7abea091a35e6a89647bded26c4b Gerrit-PatchSet: 1 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Tomas Gavenciak <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
