Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3940: Fix getting column stats through views. ......................................................................
Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/3865/2/fe/src/test/java/com/cloudera/impala/common/FrontendTestBase.java File fe/src/test/java/com/cloudera/impala/common/FrontendTestBase.java: Line 66: public class FrontendTestBase { nice, thank you! Line 180: CreateViewStmt createVieweStmt = (CreateViewStmt) AnalyzesOk(createViewSql); remove e in Viewe http://gerrit.cloudera.org:8080/#/c/3865/2/testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test File testdata/workloads/functional-planner/queries/PlannerTest/tpcds-all.test: Line 2515: | | hash predicates: ss_store_sk = s_store_sk do you know what the perf impact of these plan changes is? http://gerrit.cloudera.org:8080/#/c/3865/2/testdata/workloads/functional-planner/queries/PlannerTest/tpch-views.test File testdata/workloads/functional-planner/queries/PlannerTest/tpch-views.test: Line 1: # TPCH-Q1 this is going to be hard to verify by hand. is there something better we can do, such as compare the output directly to tpch-all.test, with some kind of search & replace? -- To view, visit http://gerrit.cloudera.org:8080/3865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie3b62a5e7e7d0e84850749108c13991647cedce6 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <[email protected]> Gerrit-Reviewer: Marcel Kornacker <[email protected]> Gerrit-HasComments: Yes
