Dan Hecht has posted comments on this change. Change subject: IMPALA-3923: fix overflow in BufferedTupleStream::GetRows() ......................................................................
Patch Set 2: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/3878/2/be/src/runtime/buffered-tuple-stream.cc File be/src/runtime/buffered-tuple-stream.cc: Line 506: if (num_rows() > numeric_limits<int>::max()) { let's add a comment to make it clear when we can delete this check so there is no question later on. something like: // RowBatch::num_rows_ is 32-bits. -- To view, visit http://gerrit.cloudera.org:8080/3878 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iabb977014d855d6edb035bf2e9519ac8b3234767 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
