Thomas Tauber-Marshall has posted comments on this change. Change subject: IMPALA-3629: Codegen TransferScratchTuples() in hdfs-parquet-scanner ......................................................................
Patch Set 6: (4 comments) http://gerrit.cloudera.org:8080/#/c/3774/5/be/src/exec/hdfs-scan-node.cc File be/src/exec/hdfs-scan-node.cc: PS5, Line 668: s > 'status' I think is a little clearer. Done PS5, Line 689: fn == NULL > The value of fn is undefined in some cases here if the above functions retu Done http://gerrit.cloudera.org:8080/#/c/3774/5/be/src/exec/hdfs-text-scanner.cc File be/src/exec/hdfs-text-scanner.cc: Line 689: *write_aligned_tuples_fn = NULL; > I think this and the other functions should initialise their output argumen Done http://gerrit.cloudera.org:8080/#/c/3774/5/be/src/exec/hdfs-text-scanner.h File be/src/exec/hdfs-text-scanner.h: Line 62: /// status of the codegen, or OK if codegen is disabled. > Line wrapping looks weird here. Done -- To view, visit http://gerrit.cloudera.org:8080/3774 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic327e437c7cd2b3f92cdb11c1e907bfee2d44ee8 Gerrit-PatchSet: 6 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Michael Ho <[email protected]> Gerrit-Reviewer: Thomas Tauber-Marshall <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
