Christopher Channing has posted comments on this change. Change subject: IMPALA-3964: Remove erroneous DCHECK in Parquet scanner. ......................................................................
Patch Set 2: (3 comments) Done http://gerrit.cloudera.org:8080/#/c/3940/2//COMMIT_MSG Commit Message: Line 18: The Fix: Removed the erroneous DCHECK. Added logic to determine if any > change the part about "Added logic" to state that we now also transfer the Done Line 20: Augmented the load_nested.py script to snappy compress each of the > mention the following things: Done http://gerrit.cloudera.org:8080/#/c/3940/2/be/src/exec/hdfs-parquet-scanner.cc File be/src/exec/hdfs-parquet-scanner.cc: Line 564: // filters/conjuncts or transfer memory ownership. > remove the "or transfer memory ownership" part since we do actually need to Done -- To view, visit http://gerrit.cloudera.org:8080/3940 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Id0955c85d18dfba4bd29a35ec95d0355da050607 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Christopher Channing <cchann...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Christopher Channing <cchann...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-HasComments: Yes
