Tim Armstrong has posted comments on this change. Change subject: IMPALA-3470: DecompressorTest is flaky. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/3954/1/be/src/util/decompress-test.cc File be/src/util/decompress-test.cc: Line 237: int truncated = rand() % 512 + 1; Can we add an ASSERT_LE(truncated, compressed_len)? It shouldn't be possible that compressed_len < 512, but it's hard to be sure without reading GenerateMultiStreamData(). -- To view, visit http://gerrit.cloudera.org:8080/3954 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7ebaa403abf45e31f38d6cf4e557d6274d877a8a Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Juan Yu <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
