Alex Behm has posted comments on this change. Change subject: IMPALA-3856,IMPALA-3871: Fix BinaryPredicate normalization for Kudu ......................................................................
Patch Set 3: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/3986/3/testdata/workloads/functional-planner/queries/PlannerTest/kudu.test File testdata/workloads/functional-planner/queries/PlannerTest/kudu.test: Line 158: ---- DISTRIBUTEDPLAN remove, PLAN is enough Line 179: ---- DISTRIBUTEDPLAN remove, PLAN is enough http://gerrit.cloudera.org:8080/#/c/3986/3/tests/query_test/test_kudu.py File tests/query_test/test_kudu.py: Line 100: def test_kudu_expr(self, vector): might be safer to mark as serial as well because once we add another one of these non-serial tests, we'll have a setup/teardown race alternatively, I'd also be ok with removing this EE test altogether because the planner test should be sufficient -- To view, visit http://gerrit.cloudera.org:8080/3986 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iae7612433a2e27f8887abe6624f9ee0f4867b934 Gerrit-PatchSet: 3 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Matthew Jacobs <[email protected]> Gerrit-HasComments: Yes
