Marcel Kornacker has posted comments on this change. Change subject: IMPALA-2809: Improve ByteSwap with builtin function or SSSE3 or AVX2. ......................................................................
Patch Set 42: (5 comments) http://gerrit.cloudera.org:8080/#/c/3081/42/be/src/util/bit-util.cc File be/src/util/bit-util.cc: Line 171: if( TEMPLATE_DATA_WIDTH == 16 ) ByteSwapFunc = SimdByteSwap::ByteSwap128; formatting if statements that span multiple lines need to have braces http://gerrit.cloudera.org:8080/#/c/3081/42/be/src/util/bit-util.h File be/src/util/bit-util.h: Line 246: /// Byteswap an array in the scalar way with some builtin optimization for the array "for arrays of ..." Line 262: typedef void (*SimdFunc)(const uint8_t* src, uint8_t* dst); this definition isn't needed here anymore Line 268: /// SimdFunc SIMD_FUNC: update Line 272: /// const void* src: the source address of the input array; no need to repeat those here, you already explained it for a preceding function -- To view, visit http://gerrit.cloudera.org:8080/3081 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I392ed5a8d5683f30f161282c228c1aedd7b648c1 Gerrit-PatchSet: 42 Gerrit-Project: Impala Gerrit-Branch: cdh5-trunk Gerrit-Owner: Youwei Wang <youwei.a.w...@intel.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Mostafa Mokhtar <mmokh...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Youwei Wang <youwei.a.w...@intel.com> Gerrit-HasComments: Yes
