Henry Robinson has posted comments on this change. Change subject: IMPALA-3893, IMPALA-3901: impala-shell prints incorrect coordinator address, overly verbose ......................................................................
Patch Set 2: (6 comments) Were any tests affected? http://gerrit.cloudera.org:8080/#/c/3994/2/be/src/util/webserver.cc File be/src/util/webserver.cc: PS2, Line 223: http_address_.hostname.compare Can you use IsWildcardAddress(http_address_) ? PS2, Line 224: If GetHostname() returns an error, hostname will be 0.0.0.0 um? if GetHostname() returns an error, hostname will be undefined. http://gerrit.cloudera.org:8080/#/c/3994/2/shell/impala_client.py File shell/impala_client.py: PS2, Line 238: esult.version, result.webserver_address Just return result? http://gerrit.cloudera.org:8080/#/c/3994/2/shell/impala_shell.py File shell/impala_shell.py: PS2, Line 686: self.webserver_address.replace("localhost", "127.0.0.1") why? Line 877: self._print_if_verbose("Query submitted at: %s (Coordinator: %s)" % (time.strftime( long line PS2, Line 880: self._print_if_verbose("Query submitted at: %s" % time.strftime( : "%Y-%m-%d %H:%M:%S", time.localtime())) does this print for 'use' statements as well? I still think that's a bit verbose. Maybe remove this branch? -- To view, visit http://gerrit.cloudera.org:8080/3994 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9d167b66f2dd8629e40a7094d21ea7ce6b43d23b Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: Yes
