Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 1: I took Sailesh's suggestion of special-casting the treatment of broadcast filters and not copying them into an intermediate filter in the filter bank. While this is a big simplification, it does make it a bit harder to track the outgoing Thrift filter data structure; the rough argument in favour of that being ok is that the incoming data structure is not tracked (yet) anyhow, so we're really moving the memory used for that to the outgoing data structure. It would be good to fix that for all Thrift structures. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-HasComments: No