Dan Hecht has posted comments on this change. Change subject: IMPALA-(3895,3859): Don't log file data on parse errors ......................................................................
Patch Set 5: > Exhaustive tests failed because the offsets for the GZIP version of > alltypeserrorornulls is different than for most other file formats. > I need to change that test to use row_regex instead. Hmm, it's going to be especially hard for users to figure out what data is malformed for compressed formats since the offset we print is the compressed file offset, right? Though I guess I'm not sure there's a better way without printing the record. -- To view, visit http://gerrit.cloudera.org:8080/4020 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I5a604f8784a9ff7b4bf878f82ee7f56697df3272 Gerrit-PatchSet: 5 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: No
