Dimitris Tsirogiannis has posted comments on this change. Change subject: IMPALA-3930,IMPALA-2570: Fix shuffle insert hint with constant partition exprs. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4162/1/testdata/workloads/functional-planner/queries/PlannerTest/insert.test File testdata/workloads/functional-planner/queries/PlannerTest/insert.test: Line 543: ==== > That doesn't seem useful to me. Is there a specific aspect of the original Maybe I misunderstood, but I thought there were two different bugs here, the one ignores the hint and the other throws an exception. If the test cases cover both that's fine by me. -- To view, visit http://gerrit.cloudera.org:8080/4162 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1084d49c95b7d867eeac3297fd2016daff0ab687 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes