Marcel Kornacker has posted comments on this change. Change subject: IMPALA-1657: Rework detection and reporting of corrupt table stats. ......................................................................
Patch Set 1: Code-Review+2 (6 comments) http://gerrit.cloudera.org:8080/#/c/4166/1/fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java File fe/src/main/java/com/cloudera/impala/planner/HdfsScanNode.java: Line 359: * Also computes totalBytes_ , totalFiles_, hasCorruptTableStats_ Line 370: if ((cardinality_ < -1) || (cardinality_ == 0 && tbl_.getTotalHdfsBytes() > 0)) { remove () from (cardinality_ < -1) - i find that easier to read because it requires less parenthesis counting Line 374: totalFiles_ += partitions_.get(0).getFileDescriptors().size(); another checkstate that we only have a single partition? Line 377: // Nothing to scan. Definitely a cardinality of 0 even if we have no stats. make this branch the first one to avoid negation Line 414: if (!(cardinality_ >= 0 || cardinality_ == -1)) { a bit easier: if (cardinality_ < -1) http://gerrit.cloudera.org:8080/#/c/4166/1/testdata/workloads/functional-planner/queries/PlannerTest/hbase.test File testdata/workloads/functional-planner/queries/PlannerTest/hbase.test: Line 495: 04:HASH JOIN [INNER JOIN] > Plan looks better, but I'm still double checking whether something is wrong that generally seems to be the case as often as it is not. :) -- To view, visit http://gerrit.cloudera.org:8080/4166 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1d3305791d96e1c23a901af7b7c109af9352bb44 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Dimitris Tsirogiannis <dtsirogian...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-HasComments: Yes
