Sailesh Mukil has posted comments on this change. Change subject: IMPALA-4014: Introduce query-wide execution state. ......................................................................
Patch Set 11: >From the discussion today: Points agreed on: - Collapse Executors and states, i.e. collapse FragmentInstanceExecutor into FragmentInstanceState, so that responsibilities and boundaries of classes are clear. - QueryExecMgr is still responsible for setting up the QueryState and creating the fragment threads for now. Once the per-query RPC is implemented, the model will change such that QueryExecMgr creates a “query" thread which sets up the QueryState and starts the fragment threads. Additionally, I'll put out a separate patch with *only* headers that are parallel with the existing headers, so that Lars can use that to work on the per-query RPC. -- To view, visit http://gerrit.cloudera.org:8080/3817 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I892091d6401acb2ea91ccb1623af54c6f9635e6c Gerrit-PatchSet: 11 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-HasComments: No