Dan Hecht has posted comments on this change. Change subject: IMPALA-2831: Bound the number of scanner threads per scan node. ......................................................................
Patch Set 4: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/4174/4/be/src/exec/hdfs-scan-node.h File be/src/exec/hdfs-scan-node.h: Line 513: /// the query option 'NUM_SCANNER_THREADS' is not set. explain that it is NUM_SCANNER_THREADS if that option is set, and explain why this default is good. ... Set to 'NUM_SCANNER_THREADS' if that query option is set, otherwise set to the number of CPU cores. Scanner threads are generally CPU bound so there's no benefit to spinning up more than the number of cores). -- To view, visit http://gerrit.cloudera.org:8080/4174 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I191988ad18d6b4caf892fc967258823edcf9681f Gerrit-PatchSet: 4 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
