Henry Robinson has posted comments on this change. Change subject: IMPALA-3610: Account for memory used by filters in the coordinator ......................................................................
Patch Set 13: (12 comments) Mostly style comments, but one question about disabling broadcast joins too early. http://gerrit.cloudera.org:8080/#/c/4066/13//COMMIT_MSG Commit Message: PS13, Line 30: Done Comment is out of date. http://gerrit.cloudera.org:8080/#/c/4066/12/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: PS12, Line 272: boost remove boost:: PS12, Line 275: std remove std:: PS12, Line 296: std remove std:: PS12, Line 299: boost remove boost:: PS12, Line 313: local local? Line 324: remove blank line PS12, Line 369: // This may be NULL while executing UDFs. : if (filter_mem_tracker_.get() != nullptr) { : filter_mem_tracker_->UnregisterFromParent(); : } Why not do this in TearDown()? Line 2074: DCHECK(state->disabled() || state->pending_count() == 0); This just DCHECKS the previous line (except covering the case where pending_count() < 0). Is it really necessary? PS12, Line 2091: filter_mem_tracker_->Release(aggregated_filter->directory.size()); nit: shouldn't you release *after* the swap()? Won't make any difference in practice. PS12, Line 2100: Disable Doesn't this mean that every filter eventually gets a 'true' in its Disabled column? That won't help us understand which filters really did get disabled for real reasons. PS12, Line 2133: Disable(coord->filter_mem_tracker_.get()); not clear - is this branch only taken if the filter is partitioned only? Otherwise one OOM for a broadcast filter will mean disabling it permanently. -- To view, visit http://gerrit.cloudera.org:8080/4066 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3c52c8a1c2e79ef370c77bf264885fc859678d1b Gerrit-PatchSet: 13 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Sailesh Mukil <sail...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
