stak...@cloudera.com has posted comments on this change. Change subject: IMPALA-3980: Re-enable Hive as a target database for the Random Query Generator ......................................................................
Patch Set 2: (9 comments) http://gerrit.cloudera.org:8080/#/c/4011/1//COMMIT_MSG Commit Message: PS1, Line 9: Changes: > Remove; redundant with line 7. Fixed PS1, Line 11: * Added hive cli options back in (removed in commit "Stress test: Various changes") > Even better, don't refer to hashes: they can and will change across branche Removed commit hash and replaced it with the commit message PS1, Line 14: * Modified MiniCluster to use HADOOP_CONF_DIR and HIVE_CONF_DIR rather than a hard-coded > Please wrap at 90 chars. Wrapped Line 15: file under IMPALA_HOME > Since unfortunately there are no unit tests for the query generator, it's i Added details about how I tested the changes http://gerrit.cloudera.org:8080/#/c/4011/1/tests/comparison/cluster.py File tests/comparison/cluster.py: PS1, Line 76: def _load_hadoop_config(self) > It seems like this should be a private method. You haven't actually changed Yes, it can be private, updated. PS1, Line 96: """ > Maybe work the logic to handle this into the method above, so two first-cla Collapsed these into one method get_hadoop_config(self, key, default=None): Line 325: > Long line; please wrap at 90. Wrapped PS1, Line 422: > Long line; please wrap at 90. Wrapped http://gerrit.cloudera.org:8080/#/c/4011/1/tests/comparison/db_connection.py File tests/comparison/db_connection.py: Line 799 > Revert this change. flake8 likes 2 lines between classes anyway. Reverted -- To view, visit http://gerrit.cloudera.org:8080/4011 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ifb1199b50a5b65c21de7876fb70cc03bda1a9b46 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: stak...@cloudera.com Gerrit-Reviewer: David Knupp <dkn...@cloudera.com> Gerrit-Reviewer: Henry Robinson <he...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-Reviewer: Taras Bobrovytsky <tbobrovyt...@cloudera.com> Gerrit-Reviewer: stak...@cloudera.com Gerrit-HasComments: Yes
