Tim Armstrong has posted comments on this change. Change subject: Add FNV, Zobrist, and SIMD hash functions to the int hash benchmark. ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/4313/1/be/src/benchmarks/int-hash-benchmark.cc File be/src/benchmarks/int-hash-benchmark.cc: Line 271: unique_ptr<uint32_t[]> ud(new uint32_t[DATA_SIZE]); > That would be interesting. OK with you to just add TODO for now? Sounds good to me. -- To view, visit http://gerrit.cloudera.org:8080/4313 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I11d48f8816d5b129858a1f773015e51049dd1d61 Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <[email protected]> Gerrit-Reviewer: Jim Apple <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-HasComments: Yes
