Lars Volker has posted comments on this change. Change subject: IMPALA-4053: Address follow up comments for IMPALA-3610 ......................................................................
Patch Set 2: (6 comments) http://gerrit.cloudera.org:8080/#/c/4306/2/be/src/runtime/coordinator.cc File be/src/runtime/coordinator.cc: Line 304: // Index into fragment_instance_states_ for source fragment instances. This does not merely look like an index. Can you comment on why we're using a set here? Line 733: row.push_back(!state.disabled() ? "true" : "false"); this line would need changing if we move pending_count into disabled() PS2, Line 2069: (state->disabled() || state->pending_count() == 0) These two mostly occur together. Maybe move the pending_count check into disabled()? Or make a new method ProcessingFinished() or similar and combine both there. PS2, Line 2078: && !state->disabled() Is it correct to check for !state->disabled() here? Can it happen that between L2069 and here the state get's disabled? PS2, Line 2092: Filter is complete, and can be released. How about "Filter has been processed and distributed completely, and can be discarded." ? PS2, Line 2147: if (pending_count_ == 0 || disabled_) { : completion_time_ = coord->query_events_->ElapsedTime(); : } Could this go into Discard()? -- To view, visit http://gerrit.cloudera.org:8080/4306 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7499558cc9d3622a9f3b68904aa5fe92a113f579 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Sailesh Mukil <[email protected]> Gerrit-Reviewer: Lars Volker <[email protected]> Gerrit-HasComments: Yes
