Kathy Sun has posted comments on this change. Change subject: IMPALA-4024: Add "system" database and expose Impala metrics as a table ......................................................................
Patch Set 19: (4 comments) 1.Refactor code in system-table-scan-node remove functions and variables that could be avoid. 2. revise Authz-test http://gerrit.cloudera.org:8080/#/c/3863/18/be/src/exec/system-table-scan-node.cc File be/src/exec/system-table-scan-node.cc: PS18, Line 94: > probably not. Done http://gerrit.cloudera.org:8080/#/c/3863/18/be/src/exec/system-table-scanner.h File be/src/exec/system-table-scanner.h: Line 38: > I think I did batched GetNext() (1024 rows per batch) Done Line 40: virtual Status Open() = 0; > But I do need size() to serve 1024 batch feature. to decide the size of nex Done http://gerrit.cloudera.org:8080/#/c/3863/18/fe/src/main/java/com/cloudera/impala/catalog/Db.java File fe/src/main/java/com/cloudera/impala/catalog/Db.java: Line 496: @Override > I don't think we need hashCode() and equals() do we? Done -- To view, visit http://gerrit.cloudera.org:8080/3863 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I7adbeb45220c468e43b424d70c30b952f6cec2cd Gerrit-PatchSet: 19 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Kathy Sun <kathy....@cloudera.com> Gerrit-Reviewer: Kathy Sun <kathy....@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
