Marcel Kornacker has posted comments on this change. Change subject: IMPALA-3905: Add single-threaded scan node. ......................................................................
Patch Set 7: Code-Review+2 (3 comments) http://gerrit.cloudera.org:8080/#/c/4113/6/be/src/exec/hdfs-scan-node-base.h File be/src/exec/hdfs-scan-node-base.h: Line 304: bool unknown_disk_id_warned_; > Done ? http://gerrit.cloudera.org:8080/#/c/4113/7/be/src/exec/hdfs-scan-node.h File be/src/exec/hdfs-scan-node.h: Line 104: boost::lock_guard<SpinLock> l(file_type_counts_); move to .cc, this isn't perf-critical and doesn't need to be inlined (it's nice to keep extra fluff out of headers) Line 141: /// This lock cannot be taken together with any other lock except lock_. what is required lock order? -- To view, visit http://gerrit.cloudera.org:8080/4113 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I98cc7f970e1575dd83875609985e1877ada3d5e0 Gerrit-PatchSet: 7 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Alex Behm <alex.b...@cloudera.com> Gerrit-Reviewer: Marcel Kornacker <mar...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
