Tim Armstrong has posted comments on this change. Change subject: IMPALA-4008: don't bake in hash table and hash join pointers ......................................................................
Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/4326/2/be/src/exec/hash-table.cc File be/src/exec/hash-table.cc: Line 185: uint32_t HashTableCtx::HashVariableLenRow( > Can we configure clang-format to not format the code this way ? I find such It doesn't look like there is an option to do that in this case. There is a penalty option for function calls but not function declarations. I tried tweaking a couple of related things but it looks like this is the behaviour you get when BinPackParameters is true. http://llvm.org/releases/3.8.0/tools/clang/docs/ClangFormatStyleOptions.html PS2, Line 317: uint8_t* > Hmm...I think I meant the first argument, not the return value. The return value has to be const if the input argument is const though. I think the only way to solve it in C++ is to add overloads, but it doesn't seem worth it. -- To view, visit http://gerrit.cloudera.org:8080/4326 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ie353666dbb5c958f0094d169306fe930ec3014c5 Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-Reviewer: Michael Ho Gerrit-Reviewer: Michael Ho <k...@cloudera.com> Gerrit-Reviewer: Tim Armstrong <tarmstr...@cloudera.com> Gerrit-HasComments: Yes
