Jim Apple has posted comments on this change. Change subject: IMPALA-4096: Allow clean.sh to work from snapshots ......................................................................
Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/4336/2/bin/clean.sh File bin/clean.sh: PS2, Line 55: git rev-parse &>dev/null > Here and elsewhere, you're missing the leading / for /dev/null unless this 1. Done 2. Changed to 2>, as (a) this is a more common idiom, (b) git rev-parse produces no output in my testing, and (c) I don't have easy access to a CentOS 5 installation. -- To view, visit http://gerrit.cloudera.org:8080/4336 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12dd9035298151557491009680d66d25c8f58c1d Gerrit-PatchSet: 2 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Dan Hecht <dhe...@cloudera.com> Gerrit-Reviewer: Jim Apple <jbap...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
