Michael Brown has posted comments on this change. Change subject: IMPALA-3718: Support subset of functional-query for Kudu ......................................................................
Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/4175/1/tests/common/test_result_verifier.py File tests/common/test_result_verifier.py: PS1, Line 333: # TINYINT). Bypass the type # checking by ignoring the actual types of the Avro Nit: You left the # when joining the line. PS1, Line 336: if 'TIMESTAMP' in expected_types: : LOG.info("TIMESTAMP columns unsupported in %s, skipping verification." %\ : file_format) : return It's weird to see this logic again. -- To view, visit http://gerrit.cloudera.org:8080/4175 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: Iada88e078352e4462745d9a9a1b5111260d21acc Gerrit-PatchSet: 1 Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Michael Brown <mi...@cloudera.com> Gerrit-HasComments: Yes
