I wanted to leave in our release procedures the opportunity for the release manager to NOT release if there are three +1s but the RM finds something he or she wants to fix first. For instance, what if we had had three +1s already before you found that JAR? Would the RM have to release?
I don't know, so I added in the extra step. On Tue, Sep 20, 2016 at 10:08 AM, Tom White <t...@cloudera.com> wrote: > Any reason this isn't a vote? Usually an RC will be voted on, and if > problems are found then another RC will be created, until the PPMC is > happy with it, at which point it can go to the IPMC. > > I ran through the legal checks and it looks good to me. I noticed that > there's a binary file (testdata/udfs/impala-hive-udfs.jar), which > should really be removed. > > Cheers, > Tom > > > On Sun, Sep 18, 2016 at 1:15 AM, Jim Apple <jbap...@cloudera.com> wrote: > > This is the second release candidate for Apache Impala (incubating) > 2.7.0: > > > > https://dist.apache.org/repos/dist/dev/incubator/impala/2.7.0/RC2/ > > > > The purpose of this thread is to gather feedback on the release > > candidate to see if a third release candidate is needed or if we can > > go ahead and vote on rc2. > > > > The git tag of the tree I made the tarball from is "2.7.0-rc2": > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git;a=tag;h= > cabaa58fa5c15b0457c520a658dc74b4d174b1c7 > > > > That is commit: > > > > 53439d3d8cdca2dd1ca2cdf2c36c6a7ef101f7e3 > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=53439d3d8cdca2dd1ca2cdf2c36c6a7ef101f7e3 > > > > and this tree: > > > > 0b8e8a3f48b8086d53ee96064668dfccd56d57cc > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala.git;a=tree;h= > 0b8e8a3f48b8086d53ee96064668dfccd56d57cc;hb=53439d3d8cdca2dd1ca2cdf2c36c6a > 7ef101f7e3 > > > > ------------------------------------------------------------------ > > > > You can find instructions for how to evaluate a release candidate here: > > > > https://cwiki.apache.org/confluence/display/IMPALA/ > DRAFT%3A+How+to+Release#DRAFT:HowtoRelease-HowtoVoteonaReleaseCandidate > > > > Here is a copy of that section of the wiki: > > > > 1. Download the tarball. Check the signature and the checksums. > > > > # change to a new directory > > cd $(mktemp -d) > > > > # Download the keys of the release managers > > wget https://dist.apache.org/repos/dist/dev/incubator/impala/KEYS > > gpg --import KEYS > > > > # Set the keys of the release managers as trusted > > gpg --edit-key jbapple trust > > # At the prompt, enter '5' for "I trust ultimately", then 'y' for > > "yes", then 'q' for "quit" > > > > # Download the release artifacts: > > wget https://dist.apache.org/repos/dist/dev/incubator/impala/x.y. > z/RCq/apache-impala-incubating-x.y.z.tar.{gz,gz.asc,gz.md5,gz.sha} > > > > # Check the checksums: > > md5sum --check apache-impala-incubating-x.y.z.tar.gz.md5 > > sha1sum --check apache-impala-incubating-x.y.z.tar.gz.sha > > > > # Check the signature: > > gpg --verify apache-impala-incubating-x.y.z.tar.gz.asc > > > > 2. Check that it matches the upstream tag > > # move to your git directory and checkout the tag: > > cd incubator-impala > > git fetch apache --tags > > git checkout x.y.z-rcw > > > > # compare the tarball and the repo: > > cd .. > > tar xzf apache-impala-incubating-x.y.z.tar.gz > > diff -r apache-impala-incubating-x.y.z incubator-impala > > # You should see something like "Only in incubator-impala: .git", but > > no other output > > > > 3. Test the release quality, possibly using bin/run-all-tests.py. > > > > 4. Check compliance with ASF release policy. Use Apache RAT and follow > > the instructions in bin/check-rat-report.py to check licence > > compliance. > > > > ------------------------------------------------------------ > ---------------------- > > > > Changes since the last release candidate: > > > > 1. Minor changes in the way the release candidate was made (directory > > name in tarball, location on dist.apache.org, filename). The current > > procedure is documented on > > https://cwiki.apache.org/confluence/pages/viewpage. > action?pageId=65869538 > > > > 2. Un-break building from non-git directories: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=9f08d1ab3c876dc1fc92c9decb8104400eaeec7c > > > > 3. RAT script to check licensing: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=85a0e36423c6c938c1a540629c16d27b3a9e1522 > > > > 4. License fixes: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=586ae2d7f357d1b2fd0d7b59dad0229e7383747d > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=d385ac72d1400a6c1eb5da6de6f8c28aba33a3d4 > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=fb646d1b06a21f44518616bd49a91b88998ff602 > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=53439d3d8cdca2dd1ca2cdf2c36c6a7ef101f7e3 > > > > 5. Remove 'cdh' from version string: > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-impala. > git;a=commit;h=046267b72e5b63b134a4ef004ccde2a268a9ae42 >
