Lars Volker has posted comments on this change. Change subject: IMPALA-4636: Add support for SLES12 for Impala/Kudu integration ......................................................................
Patch Set 2: Code-Review+2 (1 comment) I don't know enough about the cmake patch, but since we use it for Impala, too, it looks good to me. http://gerrit.cloudera.org:8080/#/c/5454/2/source/kudu/build.sh File source/kudu/build.sh: PS2, Line 18: KUDU_VERSION nit: This should be $PACKAGE_VERSION now I guess. -- To view, visit http://gerrit.cloudera.org:8080/5454 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I87d22028e08b19a1b7f39cb5def115a82560e292 Gerrit-PatchSet: 2 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes