Lars Volker has posted comments on this change. Change subject: IMPALA-4477: Bump Kudu to latest commit on master (e018a83) ......................................................................
Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/5460/1/buildall.sh File buildall.sh: Line 240: KUDU_VERSIONS="0.8.0-RC1 0.9.0-RC1 0.10.0-RC1 1.0.0-RC1 f2aeba 60aa54e a70c905006" nit: I first thought we might want to standardize the commit hashes on the same length, e.g. 7 chars. Then I realized that once a hash makes it in here and is referred to in Impala's git, it cannot even be shortened. Maybe add a comment that explains this and asks future maintainers to keep these exactly 7chars long. -- To view, visit http://gerrit.cloudera.org:8080/5460 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-MessageType: comment Gerrit-Change-Id: I6fb47f30dc6c6478a125d5d4df5be11b5797e2df Gerrit-PatchSet: 1 Gerrit-Project: Toolchain Gerrit-Branch: master Gerrit-Owner: Matthew Jacobs <m...@cloudera.com> Gerrit-Reviewer: Lars Volker <l...@cloudera.com> Gerrit-Reviewer: Matthew Jacobs <m...@cloudera.com> Gerrit-HasComments: Yes
