dockerzhang opened a new issue #1194: URL: https://github.com/apache/incubator-inlong/issues/1194
<ol>
<li>Reconstruct it according to the <a
href="https://github.com/apache/flink/tree/master/flink-core/src/main/java/org/apache/flink/configuration";
class="external-link" rel="nofollow">Flink configuration module</a> format to
make improvements for codes quality, such as these core classes <br/>
<a
href="https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigConstants.java";
class="external-link" rel="nofollow">ConfigConstants.java</a><br/>
<a
href="https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOption.java";
class="external-link" rel="nofollow">ConfigOption.java</a><br/>
<a
href="https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/ConfigOptions.java";
class="external-link" rel="nofollow">ConfigOptions.java</a><br/>
<a
href="https://github.com/apache/flink/blob/master/flink-core/src/main/java/org/apache/flink/configuration/Configuration.java";
class="external-link" rel="nofollow">Configuration.java</a><br/>
etc.</li>
<li>Classes that might need to be refactored:<br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/broker/BrokerConfig.java";
class="external-link" rel="nofollow">BrokerConfig.java</a> <br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/AbstractFileConfig.java";
class="external-link" rel="nofollow">AbstractFileConfig.java</a><br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corebase/config/TLSConfig.java";
class="external-link" rel="nofollow">TLSConfig.java</a><br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfig.java";
class="external-link" rel="nofollow">TubeClientConfig.java</a><br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/ConsumerConfig.java";
class="external-link" rel="nofollow">ConsumerConfig.java</a><br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-client/src/main/java/org/apache/tubemq/client/config/TubeClientConfigUtils.java";
class="external-link" rel="nofollow">TubeClientConfigUtils.java</a><br/>
<a
href="http://https//github.com/apache/incubator-inlong/blob/master/tubemq-server/src/main/java/org/apache/tubemq/server/common/fileconfig/MasterReplicationConfig.java";
class="external-link" rel="nofollow">MasterReplicationConfig.java</a><br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConfig.java";
class="external-link" rel="nofollow">RpcConfig.java</a><br/>
<a
href="https://github.com/apache/incubator-inlong/blob/master/tubemq-core/src/main/java/org/apache/tubemq/corerpc/RpcConstants.java";
class="external-link" rel="nofollow">RpcConstants.java</a></li>
<li>Group these configuration items based on their component
roles.Master,Broker,Client..</li>
</ol>
<i>JIRA link - <a
href="https://issues.apache.org/jira/browse/INLONG-605";>[INLONG-605]</a>
created by RocMarshal</i>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
