Hi, Thanks, I have fix both of them. Now the root artificatID is called incubator-iotdb-parent. And the mavenWrapper is declared in LICENSE and LICENSE-binary.
Best, ----------------------------------- Xiangdong Huang School of Software, Tsinghua University 黄向东 清华大学 软件学院 Justin Mclean <jus...@classsoftware.com> 于2019年7月26日周五 上午6:53写道： > Hi, > > > I think it is not very good to add "incubating" on the artifactId of the > > root pom.xml. Otherwise we have to change it if the project is > graduated.. > > By the way, I checked the artifactId of Hadoop and Spark's pom.xml files, > > one is called Hadoop-main while the other is called Spark-parent (PLC4x > > also use plc4x-parent). > > It a requirement of all incubating projects to have incubating in the name > of their releases. Spark and Hadoop are top level projects and no longer > have this requirement. > > Here’s a release checklist that good too follow. [1] > > > - Wrong header on this file? /.mvn/wrapper/MavenWrapperDownloader.java > > > > It seems the header is correct... (A apache header for java file.) > > This code is not from an ASF project, so it should use a 3rd party ALv2 > header not the ASF one, see [2]. You might also want to mention it it > LICENSE. > > Thanks, > Justin > > 1. > https://cwiki.apache.org/confluence/display/INCUBATOR/Incubator+Release+Checklist > 2. https://github.com/takari/maven-wrapper
