Hi,

+1, we will only pick bug-fix commits to 0.8.x, PRs that are not compatible 
with 0.8.0 will go to 0.9. 

Best,
--
Jialin Qiao
School of Software, Tsinghua University

乔嘉林
清华大学 软件学院

> -----原始邮件-----
> 发件人: "Julian Feinauer" <j.feina...@pragmaticminds.de>
> 发送时间: 2019-09-19 23:07:16 (星期四)
> 收件人: "dev@iotdb.apache.org" <dev@iotdb.apache.org>
> 抄送: 
> 主题: AW: Reminding of changes in RPC
> 
> Totally agree. This should be considered a change not just a fix and thus be 
> in a version 0.9.x but not in 0.8.x
> 
> Julian
> 
> Von meinem Mobiltelefon gesendet
> 
> 
> -------- Ursprüngliche Nachricht --------
> Betreff: Re: Reminding of changes in RPC
> Von: 徐毅
> An: dev@iotdb.apache.org
> Cc:
> 
> Hi,
> 
> 
>     Change definitions in rpc.thrift should be careful.
>     For example, you have jdbc with 0.8.0 and iotdb with 0.8.1 whose 
> rpc.thrit are a little bit different. It is most likely that you cannot use  
> jdbc with 0.8.0 to connect iotdb with 0.8.1 since they are not compatible.  
> This may confuse our users why two 0.8.x are not compatible?
> 
> 
>     Therefore, i would suggest that if there is no great improvement,  the 
> original definitions should be remained.
> 
> 
> Thanks
> XuYi
> 
> 
> On 9/19/2019 20:03,孙泽嵩<sz...@mails.tsinghua.edu.cn> wrote:
> Hi,
> 
> 
> I have renamed some variable and struct names in RPC in PR [1]:
> Rename TS_Status to TSStatus;
> Rename TS_StatusType to TSStatusType;
> Use TSStatus to replace TSRPCRsp. (Since it only contains TSStatus field)
> 
> 
> If you are working on JDBC or session, please pull latest master code to 
> avoid more conflicts.
> 
> 
> Besides, if any people changed RPC, remember  to maintain the file 
> `rpc-changelist.md` in service-rpc module. It is helpful for other developers 
> : )
> 
> 
> [1] https://github.com/apache/incubator-iotdb/pull/404
> 
> 
> 
> 
> BR,
> 
> 
> --
> Zesong Sun
> School of Software, Tsinghua University
> 
> 孙泽嵩
> 清华大学 软件学院

Reply via email to